Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini Cherrypick: Electrolyzer fixes. #63

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

Constellado
Copy link
Collaborator

About The Pull Request

This in theory should fix the ice electrolyzer.

This is the PR cherrypicked.
shiptest-ss13/Shiptest#3202

Changelog

🆑
fix: fixes the ice outpost's electrolyser
/:cl:

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Hydrogen now burns with the correct (I think) enthalpy, making hydrogen
TEGs viable. yay!
Komodo, Skipper, and Inkwell get instruction sheets. Crying-sun had one
and the upcoming dwayne remap adds one.
Electrolyzers now try to link when ice goes in instead of on init, which
caused certain maps to not connect.
Electrolyzer multitool linking works now.
Merits can no longer turn into a magic 0 value slip.
Replaces nt_ice passive pumps with volume pumps
(skipper keeps hydrogen, the commits lie)

Hydrogen pumps not correctly connecting to the pipenet even when the
Other recent map bug isn't in effect is still an issue, but I've got no
idea how to fix it. Leaving it as an issue for now.

fixed single wrong pixel on the sprite.
new

![image](https://github.com/user-attachments/assets/575e4ef0-5f29-4fc8-bbf6-cc2d57eb28c4)
old

![image](https://github.com/user-attachments/assets/2165bc33-f260-41ab-934d-3f6a90062277)

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
#2431 needed more testing, especially since it was an early PR of mine.
Fixes some of my mistakes.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
fix: hydrogen and combustion bugs
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@Constellado Constellado merged commit c111771 into PentestSS13:master Dec 1, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 1, 2024
@Constellado Constellado deleted the electrolyzerfix branch December 14, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants